Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add corneliusweig to krew-maintainers #1161

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Add corneliusweig to krew-maintainers #1161

merged 1 commit into from
Sep 5, 2019

Conversation

corneliusweig
Copy link
Contributor

Hey there, among the active maintainers of sigs.k8s.io/krew there is only @ahmetb who has sufficient rights to do a release of a new krew version (see kubernetes-sigs/krew#324). We would like to reduce the truck factor here, so that there are at least two of the maintainers with the appropriate rights. In particular, I need the right to create tags manually.

So I was digging into this and I found this config file where @ahmetb is listed in krew-maintainers, who apparently have write access to the repository. Is it appropriate to add me there as well (I have been krew maintainer for just a few months only)? If so, is there a particular process that needs to be followed?

Thanks in advance!

Also see the discussion here kubernetes-sigs/krew#324 (comment)

@k8s-ci-robot
Copy link
Contributor

Welcome @corneliusweig!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @corneliusweig. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Sep 5, 2019
@cblecker
Copy link
Member

cblecker commented Sep 5, 2019

/ok-to-test
/assign @ahmetb

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2019
@ahmetb
Copy link
Member

ahmetb commented Sep 5, 2019

I approve.

@cblecker
Copy link
Member

cblecker commented Sep 5, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit eef748d into kubernetes:master Sep 5, 2019
@corneliusweig corneliusweig deleted the w/krew-maintainer branch September 6, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@ahmetb ahmetb

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corneliusweig @k8s-ci-robot @cblecker @ahmetb